fix: add special handling for mellea global event loop when forked#624
Open
jakelorocco wants to merge 1 commit intomainfrom
Open
fix: add special handling for mellea global event loop when forked#624jakelorocco wants to merge 1 commit intomainfrom
jakelorocco wants to merge 1 commit intomainfrom
Conversation
Contributor
|
The PR description has been updated. Please fill out the template for your PR to be reviewed. |
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🟢 Enforce conventional commitWonderful, this rule succeeded.Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
|
Contributor
Author
|
|
jakelorocco
force-pushed
the
jal/async-with-forks
branch
from
8a664ff to
e940c95
Compare
jakelorocco
force-pushed
the
jal/async-with-forks
branch
from
e940c95 to
cbd91e1
Compare
psschwei
approved these changes
Mar 12, 2026
| ctx = multiprocessing.get_context("fork") | ||
|
|
||
| def child(): | ||
| import mellea.helpers.event_loop_helper as elh |
Contributor
Author
There was a problem hiding this comment.
Probably not but it ensures that the singleton patten works across forks.
Contributor
Author
|
Will wait for Zhang-Wei to confirm this fixes his issues with Agent Lightning before merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Misc PR
Type of PR
Description
Added special handling for Mellea's global event loop to handle cases where the process is forked. Added a test case for this scenario as well.
Testing