test: Add tests for intrinsics-related formatters#609
test: Add tests for intrinsics-related formatters#609jakelorocco merged 8 commits intogenerative-computing:mainfrom
Conversation
Signed-off-by: Fred Reiss <frreiss@us.ibm.com>
Signed-off-by: Fred Reiss <frreiss@us.ibm.com>
Signed-off-by: Fred Reiss <frreiss@us.ibm.com>
|
The PR description has been updated. Please fill out the template for your PR to be reviewed. |
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🟢 Enforce conventional commitWonderful, this rule succeeded.Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
|
|
CI appears to be up to its usual shenanigans. Tests are passing on my machine. |
|
Thanks @frreiss; these changes / tests look reasonable. I will try to investigate the CI failures soon. I don't want to merge and break the checks on other PRs if possible. |
|
I will continue investigating, but I believe this is probably due to memory and/or storage constraints. If I'm reading the tests correctly, the test is failing on |
Signed-off-by: Fred Reiss <frreiss@us.ibm.com>
Signed-off-by: Fred Reiss <frreiss@us.ibm.com>
Signed-off-by: Fred Reiss <frreiss@us.ibm.com>
|
CI passing now. |
|
@frreiss, are you certain it was a timeout issue? I'm seeing the failed jobs getting cancelled after 8-13minutes. |
The error condition is consistent with a timeout. Here's an example stack trace: (from the build at https://github.com/generative-computing/mellea/actions/runs/22880035073/job/66523072098#step:13:307). From the stack trace, it looks like something is sending a cancellation signal inside the Javascript code that runs the workflow. The Github records for these builds tend to show a time that is less than 15 minutes (13:31 in the case of the above build), but actual wall clock time from the workflow starting until the first failed test run is very close to 15 minutes. Many time-consuming tests are disabled when running in CI mode; see https://github.com/search?q=repo%3Agenerative-computing%2Fmellea%20gh_run&type=code |
|
Okay, confirmed it's a timeout issue by testing with an extended timeout here: #632. I will approve / merge these changes as is and will discuss with the larger team about extending the timeout / winnowing down our tests. Thank you! |
8003b44
Misc PR
Type of PR
Description
This PR adds additional tests for the intrinsics-related formatting code added in #571. I've also added a dependency on the
pytest-recordingplugin that several of these tests use.