Skip to content

test: Add tests for intrinsics-related formatters#609

Merged
jakelorocco merged 8 commits intogenerative-computing:mainfrom
frreiss:granite_common2
Mar 12, 2026
Merged

test: Add tests for intrinsics-related formatters#609
jakelorocco merged 8 commits intogenerative-computing:mainfrom
frreiss:granite_common2

Conversation

@frreiss
Copy link
Collaborator

@frreiss frreiss commented Mar 9, 2026

Misc PR

Type of PR

  • Bug Fix
  • New Feature
  • Documentation
  • Other

Description

This PR adds additional tests for the intrinsics-related formatting code added in #571. I've also added a dependency on the pytest-recording plugin that several of these tests use.

frreiss added 4 commits March 9, 2026 11:52
Signed-off-by: Fred Reiss <frreiss@us.ibm.com>
Signed-off-by: Fred Reiss <frreiss@us.ibm.com>
Signed-off-by: Fred Reiss <frreiss@us.ibm.com>
@frreiss frreiss requested a review from a team as a code owner March 9, 2026 23:44
@github-actions
Copy link
Contributor

github-actions bot commented Mar 9, 2026

The PR description has been updated. Please fill out the template for your PR to be reviewed.

@mergify
Copy link

mergify bot commented Mar 9, 2026

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

🟢 Enforce conventional commit

Wonderful, this rule succeeded.

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

  • title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert|release)(?:\(.+\))?:

@frreiss frreiss changed the title [test] Add tests for intrinsics-related formatters test: Add tests for intrinsics-related formatters Mar 9, 2026
@frreiss
Copy link
Collaborator Author

frreiss commented Mar 10, 2026

CI appears to be up to its usual shenanigans. Tests are passing on my machine.

@jakelorocco
Copy link
Contributor

Thanks @frreiss; these changes / tests look reasonable. I will try to investigate the CI failures soon. I don't want to merge and break the checks on other PRs if possible.

@jakelorocco
Copy link
Contributor

I will continue investigating, but I believe this is probably due to memory and/or storage constraints. If I'm reading the tests correctly, the test is failing on test_run_transformers which is the first test that starts loading new models / downloading adapters.

frreiss added 3 commits March 10, 2026 14:25
Signed-off-by: Fred Reiss <frreiss@us.ibm.com>
Signed-off-by: Fred Reiss <frreiss@us.ibm.com>
Signed-off-by: Fred Reiss <frreiss@us.ibm.com>
@frreiss
Copy link
Collaborator Author

frreiss commented Mar 10, 2026

CI passing now.

@jakelorocco
Copy link
Contributor

@frreiss, are you certain it was a timeout issue? I'm seeing the failed jobs getting cancelled after 8-13minutes.

@frreiss
Copy link
Collaborator Author

frreiss commented Mar 12, 2026

@frreiss, are you certain it was a timeout issue? I'm seeing the failed jobs getting cancelled after 8-13minutes.

The error condition is consistent with a timeout. Here's an example stack trace:

test/formatters/granite/test_intrinsics_formatters.py::test_reparse_json[bare_string.json] PASSED [ 51%]
##[debug]Re-evaluate condition on job cancellation for step: 'Run Tests'.
test/formatters/granite/test_intrinsics_formatters.py::test_run_transformers[answerability_simple] 
Error: The operation was canceled.
##[debug]System.OperationCanceledException: The operation was canceled.
##[debug]   at System.Threading.CancellationToken.ThrowOperationCanceledException()
##[debug]   at GitHub.Runner.Sdk.ProcessInvoker.ExecuteAsync(String workingDirectory, String fileName, String arguments, IDictionary`2 environment, Boolean requireExitCodeZero, Encoding outputEncoding, Boolean killProcessOnCancel, Channel`1 redirectStandardIn, Boolean inheritConsoleHandler, Boolean keepStandardInOpen, Boolean highPriorityProcess, CancellationToken cancellationToken)
##[debug]   at GitHub.Runner.Common.ProcessInvokerWrapper.ExecuteAsync(String workingDirectory, String fileName, String arguments, IDictionary`2 environment, Boolean requireExitCodeZero, Encoding outputEncoding, Boolean killProcessOnCancel, Channel`1 redirectStandardIn, Boolean inheritConsoleHandler, Boolean keepStandardInOpen, Boolean highPriorityProcess, CancellationToken cancellationToken)
##[debug]   at GitHub.Runner.Worker.Handlers.DefaultStepHost.ExecuteAsync(IExecutionContext context, String workingDirectory, String fileName, String arguments, IDictionary`2 environment, Boolean requireExitCodeZero, Encoding outputEncoding, Boolean killProcessOnCancel, Boolean inheritConsoleHandler, String standardInInput, CancellationToken cancellationToken)
##[debug]   at GitHub.Runner.Worker.Handlers.ScriptHandler.RunAsync(ActionRunStage stage)
##[debug]   at GitHub.Runner.Worker.ActionRunner.RunAsync()
##[debug]   at GitHub.Runner.Worker.StepsRunner.RunStepAsync(IStep step, CancellationToken jobCancellationToken)
##[debug]Finishing: Run Tests

(from the build at https://github.com/generative-computing/mellea/actions/runs/22880035073/job/66523072098#step:13:307).

From the stack trace, it looks like something is sending a cancellation signal inside the Javascript code that runs the workflow.

The Github records for these builds tend to show a time that is less than 15 minutes (13:31 in the case of the above build), but actual wall clock time from the workflow starting until the first failed test run is very close to 15 minutes.

Many time-consuming tests are disabled when running in CI mode; see https://github.com/search?q=repo%3Agenerative-computing%2Fmellea%20gh_run&type=code

@jakelorocco
Copy link
Contributor

Okay, confirmed it's a timeout issue by testing with an extended timeout here: #632.

I will approve / merge these changes as is and will discuss with the larger team about extending the timeout / winnowing down our tests.

Thank you!

@jakelorocco jakelorocco enabled auto-merge March 12, 2026 18:38
@jakelorocco jakelorocco added this pull request to the merge queue Mar 12, 2026
Merged via the queue into generative-computing:main with commit 8003b44 Mar 12, 2026
8 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants