feat/ARE-218: Add are-services & adapt modules/fhir-profiles-metadata…#32
feat/ARE-218: Add are-services & adapt modules/fhir-profiles-metadata…#32Noves-Developers wants to merge 4 commits intogematik:mainfrom
Conversation
| - uri: | ||
| prefix: /gateway/are | ||
| - uri: | ||
| prefix: /api/are-token |
There was a problem hiding this comment.
Intern sollen die Services immer über den Root Pfad erreichbar sein
| %{ endif ~} | ||
| prefix: /gateway/are | ||
| - uri: | ||
| prefix: /api/are-token |
There was a problem hiding this comment.
Please review the documentation again and adjust the paths.
There was a problem hiding this comment.
Wie in der Doku beschrieben findet jetzt ein rewrite von /gateway/are auf root statt
|
|
||
| ANPS_BASE_URL: "http://are-notification-processing-service.${namespace}.svc.cluster.local" | ||
| ANPS_SURVEILLANCE_PATH: "/surveillance/respiratory-infections/v1/fhir/$process-are-notification" | ||
| KEYCLOAK_TOKEN_LAB_URI: "https://${core_hostname}/auth/realms/LAB/protocol/openid-connect/token" |
There was a problem hiding this comment.
Wozu braucht ihr diesen Endpunkt? Token werden auf istio Ebene geprüft und das Gateway bekommt den Token über das portal für die Meldungen
| virtualServiceHttpRules: | ||
| - match: | ||
| - uri: | ||
| prefix: /surveillance/respiratory-infections/v1/fhir/ |
There was a problem hiding this comment.
Intern sollen die Services immer über den root Pfad erreichbar sein, docu
There was a problem hiding this comment.
Wurde umgesetzt – der ANPS ist ausschließlich intern über das Gateway erreichbar
| mfIgs: | ||
| igsGatewayUrl: "${context_path}/gateway/are" |
There was a problem hiding this comment.
ihr macht nix mit igs daher sind die Parameter hier falsch
| - headers: | ||
| gateway-request: | ||
| exact: "false" |
There was a problem hiding this comment.
das wird nicht mehr benötigt da die Pfade für Gateway und Portal getrennt wurden
| gateway-request: | ||
| exact: "false" | ||
| uri: | ||
| prefix: /are |
There was a problem hiding this comment.
Wurde angepasst: von /portal/are wird jetzt auf / umgeleitet über ISTIO
| - headers: | ||
| gateway-request: | ||
| exact: "false" |
| gateway-request: | ||
| exact: "false" | ||
| uri: | ||
| prefix: ${context_path}/are |
There was a problem hiding this comment.
| prefix: ${context_path}/are | |
| prefix: ${context_path}/portal/are |
There was a problem hiding this comment.
Wurde angepasst: von /portal/are wird jetzt auf / umgeleitet über ISTIO
| %{ if feature_flag_new_api_endpoints ~} | ||
| - match: | ||
| - uri: | ||
| prefix: ${context_path}/portal/are | ||
| rewrite: | ||
| uri: / | ||
| %{ endif ~} |
There was a problem hiding this comment.
Das FeatureFlag wurde schon ausgebaut und das braucht ihr nicht mehr
| %{ if feature_flag_new_api_endpoints ~} | |
| - match: | |
| - uri: | |
| prefix: ${context_path}/portal/are | |
| rewrite: | |
| uri: / | |
| %{ endif ~} |
| @@ -0,0 +1,85 @@ | |||
| # Values for the validation-service-are Helm Template | |||
There was a problem hiding this comment.
Bitte schaut euch den Validation-Service Aufbau nochmal an, der arbeitet mit einem istio delegation Service und damit braucht ihr einen validation-service und einen validation-service-are
are/applications/variables.tf
Outdated
| variable "storage_hostname" { | ||
| type = string | ||
| description = "The URL to access the S3 compatible storage (minio)" | ||
| default = "storage" | ||
| } | ||
|
|
There was a problem hiding this comment.
Wurde fälschlicherweise aus eurem Code übernommen und entfernt
are/istio.tf
Outdated
| values = [ | ||
| templatefile("${local.chart_source_path}/policies-authorizations/istio-values.tftpl.yaml", { | ||
| namespace = var.target_namespace, | ||
| feature_flag_new_api_endpoints = try(module.application_flags.service_feature_flags["policies-authorizations"].FEATURE_FLAG_NEW_API_ENDPOINTS, false) |
There was a problem hiding this comment.
das feature_flag_new_api_endpoints ist ausgebaut
- Remove unused env var from gateway app-values - Remove unused config param from portal-are app-values - Remove unused module storage_hostname from are namespace - Remove deprecated modules from validation-service-are - Remove deprecated feature flag new api endpoints from namespace are - Adapt URL istio handling to comply with demis/gematik standards
- Remove unused env var from gateway app-values - Remove unused config param from portal-are app-values - Remove unused module storage_hostname from are namespace - Remove deprecated modules from validation-service-are - Remove deprecated feature flag new api endpoints from namespace are - Adapt URL istio handling to comply with demis/gematik standards
… for reuse - Add charts & config for portal-are, are-gateway, are-notification-processing-service, validation-service-are - Add feature-flags to disable portal-are - Add are-profile-snapshots to validation in modules/fhir-profiles-metadata
- Remove unused env var from gateway app-values - Remove unused config param from portal-are app-values - Remove unused module storage_hostname from are namespace - Remove deprecated modules from validation-service-are - Remove deprecated feature flag new api endpoints from namespace are - Adapt URL istio handling to comply with demis/gematik standards
- Remove unused env var from gateway app-values - Remove unused config param from portal-are app-values - Remove unused module storage_hostname from are namespace - Remove deprecated modules from validation-service-are - Remove deprecated feature flag new api endpoints from namespace are - Adapt URL istio handling to comply with demis/gematik standards
- Adapt URL istio handling to comply with demis/gematik standards - Remove deprecated FIXME from chart-validation_service_are.tf - Remove all remaining feature flag new api endpoints
4 participants
… for reuse