Fix option ingredients being overwriten#2341
Open
C85297 wants to merge 1 commit intogchq:masterfrom
Open
Conversation
C85297
force-pushed
the
646-fix-populateoptions-overriding
branch
from
ca4baff to
9a83e43
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix option ingredients value being overwriten, discarding a loaded recipe.
Currently, when a recipe is loaded, the saved arguments are loaded, and then a change event is triggered for each argument. For
populateOptioningredients, that change event reapplied the selected populate value to the target argument, replacing the saved custom value.Added
data-targetmetadata to renderedpopulateOption/populateMultiOptionselect elements so recipe-loading event logic can identify their target argument.When the target already has a value, the change event is skipped.
Existing Issue
Closes #646
AI disclosure
GPT 5.5
Test Coverage
👍 UI test added based on behaviour in #646