Fix URL encoding incorrectly converting input to UTF-8#2340
Open
C85297 wants to merge 3 commits intogchq:masterfrom
Open
Fix URL encoding incorrectly converting input to UTF-8#2340C85297 wants to merge 3 commits intogchq:masterfrom
C85297 wants to merge 3 commits intogchq:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The URL Encode operation takes a string input - this means CyberChef will convert a bytes output from a previous operation into a UTF-8 string before passing it to the URL Encode operation.
This would cause CyberChef to encode invalid UTF-8 strings when operating on non UTF-8 binary data, causing bad output from URL Encode.
Fixed by making URL Encode operation operate on binary input.
The operation still outputs strings, with the binary input URL encoded.
Existing Issue
#584
AI disclosure
GPT 5.5
Test Coverage
👍