fix: detect bun.lock (Bun v1.2+ text lockfile) in diff-scope CONFIG#1649
Open
hiSandog wants to merge 1 commit into
Open
fix: detect bun.lock (Bun v1.2+ text lockfile) in diff-scope CONFIG#1649hiSandog wants to merge 1 commit into
hiSandog wants to merge 1 commit into
Conversation
gstack-diff-scope only matched the legacy binary lockfile `bun.lockb` but not the newer text-based `bun.lock` introduced in Bun v1.2+. Projects using current Bun versions were silently missing the SCOPE_CONFIG signal when only the lockfile changed. 🤖 Generated with [Qoder][https://qoder.com]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bin/gstack-diff-scopeonly matched the legacy binary lockfilebun.lockbbut not the newer text-basedbun.lockintroduced in Bun v1.2+. Projects using current Bun versions were silently missing theSCOPE_CONFIGsignal when only the lockfile changed.bun.lockto the CONFIG detection pattern ingstack-diff-scopeTest plan
bun.lockis now detected asSCOPE_CONFIG=truebun.lockb(legacy) is still detected correctlydetects config via bun.lock (Bun v1.2+ text lockfile)todiff-scope.test.ts🤖 Generated with [Qoder][https://qoder.com]