Skip to content

fix(gstack-paths): shell-quote output so eval is safe for paths with spaces #1580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yannickspiess wants to merge 1 commit into
base: main
Choose a base branch
from
+12 −6
Open

fix(gstack-paths): shell-quote output so eval is safe for paths with spaces #1580

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 12 additions & 6 deletions bin/gstack-paths
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,11 +13,17 @@
# PLAN_ROOT: GSTACK_PLAN_DIR -> CLAUDE_PLANS_DIR -> $HOME/.claude/plans -> .claude/plans
# TMP_ROOT: TMPDIR -> TMP -> .gstack/tmp (and mkdir -p, best-effort)
#
# Security: output values are not sanitized — callers may receive paths with
# shell-special characters if env vars contain them. Skills should always quote
# expansions ("$GSTACK_STATE_ROOT", not $GSTACK_STATE_ROOT).
# Output values are shell-quoted so eval "$(gstack-paths)" is safe for paths
# containing spaces, $, ;, backticks, and other metacharacters. Single quotes
# are used for portability (POSIX sh / bash / zsh / dash).
set -u

# Wrap a path in single quotes, escaping any embedded single quotes.
# Produces output safe for: eval "$(gstack-paths)"
_shell_quote() {
printf "'%s'" "$(printf '%s' "$1" | sed "s/'/'\\\\''/g")"
}

# State root: where gstack writes projects/, sessions/, analytics/.
if [ -n "${GSTACK_HOME:-}" ]; then
_state_root="$GSTACK_HOME"
Expand Down Expand Up @@ -56,6 +62,6 @@ fi
# will discover that on their own write attempt. Don't fail the eval here.
mkdir -p "$_tmp_root" 2>/dev/null || true

echo "GSTACK_STATE_ROOT=$_state_root"
echo "PLAN_ROOT=$_plan_root"
echo "TMP_ROOT=$_tmp_root"
printf 'GSTACK_STATE_ROOT=%s\n' "$(_shell_quote "$_state_root")"
printf 'PLAN_ROOT=%s\n' "$(_shell_quote "$_plan_root")"
printf 'TMP_ROOT=%s\n' "$(_shell_quote "$_tmp_root")"