Don't freak out if a package has an empty or short Date#4280
Merged
olexandr-konovalov merged 1 commit intogap-system:masterfrom Feb 22, 2021
Merged
Don't freak out if a package has an empty or short Date#4280olexandr-konovalov merged 1 commit intogap-system:masterfrom
olexandr-konovalov merged 1 commit intogap-system:masterfrom
Conversation
I've had a package prototype sitting around with an empty Date field. While of course the validator rejects that, the package loading code should not, or at least should not run into a break loop.
fingolfin
added
regression
olexandr-konovalov
added
the
release notes: not needed
wucas
approved these changes
Feb 22, 2021
Contributor
wucas
left a comment
wucas
left a comment
There was a problem hiding this comment.
Yes that's an unfortunate (and somewhat embarrassing) oversight on my part (not checking all assumptions of the code^^). But the fix looks sensible to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a regression from PR #3355.
I've had a package prototype sitting around with an empty Date field.
While of course the validator rejects that, the package loading code
should not, or at least should not run into a break loop.
No test case, but I think the problem and fix are obvious.