fix: pass context_id instead of browser_id to BrowserContext.close#33
Open
fix: pass context_id instead of browser_id to BrowserContext.close#33
Conversation
Owner
|
Hey @itq148, if you could re-push with a signed commit that would be excellent. |
Author
|
I'll take care of it within 24 hours. Thanks for the notice! |
auto-merge was automatically disabled
April 2, 2026 10:52
Head branch was pushed to by a user without write access
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I happened to found this little typo/bug.
Although it's a minor issue it's quite misleading.
Actually I passed browser_id, not context_id.