[WIP] FSharp.Compiler.Service 43.12.201 #850
Draft
Numpsy wants to merge 9 commits intofsprojects:masterfrom
Draft
[WIP] FSharp.Compiler.Service 43.12.201 #850Numpsy wants to merge 9 commits intofsprojects:masterfrom
Numpsy wants to merge 9 commits intofsprojects:masterfrom
Conversation
…eing too long" This reverts commit de27b1b.
Most of the changes are down to the LetOrUse changes in dotnet/fsharp#19090. The ExpressionUtilities.LetOrUse active pattern was taken from an implementation detail of that change as well as it avoids using when clauses in lots of places.
Numpsy
commented
Mar 15, 2026
| | SynExpr.LetOrUse(_, _, bindings, body, _, _) -> | ||
| let instanceNames = extraFromBindings bindings List.Empty |> Set.ofList | ||
| processLetBinding instanceNames body returnEmptyArray | ||
| | SynExpr.LetOrUse letOrUse when not letOrUse.IsBang -> |
Contributor
Author
There was a problem hiding this comment.
This one is using when because when I tried the active pattern I got error FS3569: The member or function 'processLetBinding' has the 'TailCallAttribute' attribute, but is not being used in a tail recursive way.
Contributor
Author
|
Looks like the performance is still bad without #845 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This contains the whole of #770, plus an extra commit to update to FCS 43.12.201 (I'm not clear what's going on with the version numbers here)
Needs a review to see if the 'ExpressionUtilities.LetOrUse' helper is the right approach.