Open
Conversation
for tool bookings. I have tested it as much as possible.
Contributor
georgelgeback
left a comment
georgelgeback
left a comment
There was a problem hiding this comment.
We need to think more about the required permissions to add bookings, maybe we should add another tool_booking_request model for regular members? Everything else looks great though, smart solution for checking if there are too many booked tools in a range.
| class ToolBookingRead(BaseSchema): | ||
| id: int | ||
| tool: SimpleToolRead | ||
| amount: int |
Contributor
There was a problem hiding this comment.
Amount is in SimpleToolRead too. Do we need both?
| return tool | ||
|
|
||
|
|
||
| @tool_router.get("/", response_model=list[ToolRead], dependencies=[Permission.require("view", "Tools")]) |
Contributor
There was a problem hiding this comment.
This should probably be member perms, not admin. As far as I can see no sensitive data is in ToolRead.
| return db.query(Tool_DB).all() | ||
|
|
||
|
|
||
| @tool_router.get("/{tool_id}", response_model=ToolRead, dependencies=[Permission.require("view", "Tools")]) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.