Skip to content

Switching from our own Peekable implementation to more-itertools.peekable.#1376

Merged
simonvoelcker merged 1 commit intofrequenz-floss:v1.x.xfrom
simonvoelcker:more-itertools-peekable
Mar 17, 2026
Merged

Switching from our own Peekable implementation to more-itertools.peekable.#1376
simonvoelcker merged 1 commit intofrequenz-floss:v1.x.xfrom
simonvoelcker:more-itertools-peekable

Conversation

@simonvoelcker
Copy link
Copy Markdown
Contributor

@simonvoelcker simonvoelcker commented Mar 16, 2026

Addresses #1325 and #1326.

Switching to more-itertools.peekable as suggested in the original thread.

Signed-off-by: Simon Völcker <simon.voelcker@frequenz.com>
@simonvoelcker simonvoelcker self-assigned this Mar 16, 2026
@github-actions github-actions bot added part:docs Affects the documentation part:tooling Affects the development tooling (CI, deployment, dependency management, etc.) part:data-pipeline Affects the data pipeline labels Mar 16, 2026
@simonvoelcker simonvoelcker marked this pull request as ready for review March 16, 2026 15:08
@simonvoelcker simonvoelcker requested a review from a team as a code owner March 16, 2026 15:08
@simonvoelcker simonvoelcker requested review from ela-kotulska-frequenz and removed request for a team March 16, 2026 15:08
Copy link
Copy Markdown
Contributor

@llucax llucax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment about the release notes, the rest LGTM.

@simonvoelcker simonvoelcker force-pushed the more-itertools-peekable branch from 54c8d13 to 5ae3819 Compare March 17, 2026 09:33
@simonvoelcker simonvoelcker added the cmd:skip-release-notes It is not necessary to update release notes for this PR label Mar 17, 2026
@simonvoelcker simonvoelcker enabled auto-merge March 17, 2026 10:00
@simonvoelcker simonvoelcker added this pull request to the merge queue Mar 17, 2026
@github-project-automation github-project-automation bot moved this from To do to Review approved in Python SDK Roadmap Mar 17, 2026
Merged via the queue into frequenz-floss:v1.x.x with commit ef26846 Mar 17, 2026
6 of 7 checks passed
@simonvoelcker simonvoelcker deleted the more-itertools-peekable branch March 17, 2026 10:10
@github-project-automation github-project-automation bot moved this from Review approved to Done in Python SDK Roadmap Mar 17, 2026
@llucax llucax added this to the v1.0.0-rc2205 milestone Apr 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cmd:skip-release-notes It is not necessary to update release notes for this PR part:data-pipeline Affects the data pipeline part:docs Affects the documentation part:tooling Affects the development tooling (CI, deployment, dependency management, etc.)

Projects

Development

Successfully merging this pull request may close these issues.

2 participants