Make template aware of private repos#555
Open
llucax wants to merge 10 commits intofrequenz-floss:v0.x.xfrom
Open
Make template aware of private repos#555llucax wants to merge 10 commits intofrequenz-floss:v0.x.xfrom
llucax wants to merge 10 commits intofrequenz-floss:v0.x.xfrom
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
github-actions
bot
added
the
part:template
Contributor
Author
|
Ready for review |
This variable defaults to true/yes when the license is Proprietary and will be used to automatically switch features on and off in templates. Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
Instead of adding credential passing to both private and public repos, add them uncommented only for private repos. Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
Private repos should not publish-docs nor publish-to-pypi, so we only create those jobs for public repos. Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
This job is now only added for public repos, so there is no need to pass credentials. Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
Golden tests are done for all repo types setting them as private repos, and a full generation integration smoke test is done for an API private repo. Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a new
private_repovariable to the cookiecutter template. This variable defaults to true/yes when the license is Proprietary and will be used to automatically switch features on and off in templates.Private repos now:
publish-docsandpublish-to-pypijobs in the CI workflow.