Fix auth for sample upsert stream#48
Merged
Marenz merged 3 commits intofrequenz-floss:v0.x.xfrom Apr 7, 2026
Merged
Conversation
Update test helpers and assertions to match the d9a23f3 proto changes: market_area moved to MarketLocationRef, MarketLocationId.value wrapped in MarketLocationIdValue, structured errors replace flat success/error_code fields. Register the integration pytest mark in pyproject.toml. Signed-off-by: Mathias L. Baumann <mathias.baumann@frequenz.com>
Marenz
requested review from
daniel-zullo-frequenz
and removed request for
a team
github-actions
bot
added
part:tests
Marenz
force-pushed
the
fix/api-update-market-area-refactor
branch
from
3eab7c9 to
3b1e776
Compare
Marenz
force-pushed
the
fix/api-update-market-area-refactor
branch
5 times, most recently
from
9f51ff3 to
4973d72
Compare
daniel-zullo-frequenz
previously approved these changes
Apr 7, 2026
Contributor
daniel-zullo-frequenz
left a comment
daniel-zullo-frequenz
left a comment
There was a problem hiding this comment.
Only have a question about a test, and LGTM
The client got authentication and signing metadata from frequenz-client-base only for unary-unary and unary-stream RPCs. UpsertMarketLocationSamplesStream is a streaming upsert call, so it missed the key, timestamp, nonce, and signature metadata and the service rejected it with a missing-signature authentication error. Attach the same metadata explicitly for the upsert stream call and add a regression test covering the streaming path. Signed-off-by: Mathias L. Baumann <mathias.baumann@frequenz.com>
Marenz
force-pushed
the
fix/api-update-market-area-refactor
branch
from
4973d72 to
ea73ca8
Compare
daniel-zullo-frequenz
previously approved these changes
Apr 7, 2026
Integration tests now use testcontainers to spin up GreptimeDB and the marketmeteringd service binary automatically. - Added testcontainers and requests dependencies to dev-pytest - Created conftest.py with fixtures for: - GreptimeDB container - marketmeteringd service process - Database schema initialization - Updated test_integration.py to use new fixtures - Tests skip automatically when Docker is unavailable Requires: - Docker running - Service binary at ../frequenz-service-marketmetering/target/release/marketmeteringd Signed-off-by: Mathias L. Baumann <mathias.baumann@frequenz.com>
Marenz
changed the title
Marenz
changed the title
Marenz
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The client currently gets auth and signing metadata from frequenz-client-base only for unary-unary and unary-stream RPCs. UpsertMarketLocationSamplesStream is a streaming upsert call, so it missed the key, timestamp, nonce, and signature metadata and the service rejected it with a missing-signature authentication error.
This attaches the same metadata explicitly for the upsert stream call and adds a regression test covering the streaming path.
Verified with: