Conversation
There was a problem hiding this comment.
Pull request overview
This PR enhances test coverage for the safe() method by adding explicit tests for async function scenarios and improves the clarity of implementation comments.
Key Changes:
- Added test coverage for async functions that reject and resolve in both server and client contexts
- Updated the
safe()implementation comment inclient.tsto more accurately describe that it accepts both promises and functions
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/errata/test/errata.test.ts | Adds two new tests covering async function rejection and resolution scenarios for the server-side safe() method |
| packages/errata/test/client.test.ts | Adds two new tests covering async function rejection and resolution scenarios for the client-side safe() method |
| packages/errata/src/client.ts | Updates the implementation comment to clarify that safe() accepts both promises and functions (replaces "Promise/helper" with "Promise helper or function") |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.