Skip to content

make_fossa_deps_conan.py conan 2.22 graph info compatability #1629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
csasarak wants to merge 3 commits into
base: master
Choose a base branch
from
Open

make_fossa_deps_conan.py conan 2.22 graph info compatability #1629

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
03eb53f
make_fossa_deps_conan.py conan 2.22 graph info compatability
TheIceman2706 Jan 8, 2026
103eff7
Merge branch 'master' into fossa/iceman/patch-1
csasarak Jan 12, 2026
03c885a
Merge branch 'master' into fossa/iceman/patch-1
csasarak Jan 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions docs/walkthroughs/make_fossa_deps_conan.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,9 +125,10 @@ def mk_fossa_deps(graph):

vendored_deps = []
custom_deps = []
for node in graph.get('nodes', []):
for nodeName in graph.get('nodes', []):
node = graph['nodes'][nodeName]
Comment on lines +128 to +129
Copy link
Copy Markdown
Contributor

@spatten spatten Jan 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will break on older versions of conan, right? Do we want to support both versions?

I think we could do that by looking at the type of graph.get('nodes', []). Something like this:

  nodes_data = graph.get('nodes', [])
  if isinstance(nodes_data, list):
      nodes_iter = nodes_data  # Conan 1.x
  else:
      nodes_iter = nodes_data.values()  # Conan 2.x

It would be worth testing against both versions, IMO, to make sure that there aren't other breaking changes

label = node.get("label")
if label.lower() in ["conanfile.txt", "conanfile.py"]:
if label.lower() in ["conanfile.txt", "conanfile.py"] or node.get("recipe") == "Consumer":
logging.info(f"excluding {label} from fossa-deps, as this is a manifest file, not a dependency")
continue

Expand All @@ -140,7 +141,10 @@ def mk_fossa_deps(graph):
continue

pkg_id = node.get("package_id", "none")
name, raw_version = name_version_of(label)
name = node.get("name")
raw_version = node.get("version")
if not name or not raw_version:
name, raw_version = name_version_of(label)
version_params = urllib.parse.urlencode({'package_id': pkg_id}, doseq=True)
version = f"{raw_version},{version_params}"

Expand Down Expand Up @@ -181,4 +185,6 @@ def get_graph(user_args = []):

if __name__ == "__main__":
graph = get_graph(sys.argv[1:])
mk_fossa_deps(graph)
if 'graph' in graph:
graph = graph['graph']
mk_fossa_deps(graph)
Loading