Bugs, accessibility, new input types, Minimal Design tier#5
Merged
Bugs, accessibility, new input types, Minimal Design tier#5
Conversation
- Remove empty <h2 title="hallo"> (no content, debug attribute)
- Fix slider oninput: hyphenated names are not valid JS identifiers
- Fix pattern title: said 'uppercase letters' but pattern is [0-9]{3}
- Fix design-basic.css: add missing semicolon, wrap bare property in
a selector, replace undefined --text-color-pos with --color-text
- Update CLAUDE.md: nav should be collapsed by default
https://claude.ai/code/session_01JwsuyxwfMZfKQhT9twfkRY
Labels: replace all state-description labels with realistic field names (Full name, Password, Comment, Country, Region, Appointment, Volume, etc.) so screen readers announce meaningful content, not just the element state. Navigation: replace dynamic skip-link generator with a static collapsed <details>/<summary> nav listing all 11 sections. Each fieldset gets a stable id. The Cash dependency for nav generation is removed; design-tier toggle logic is kept. Colour contrast: update :root colour tokens to pass WCAG AAA (7:1). Light mode — text #111111 on #f5f5f5 (~16:1); link #003781 (~9:1). Dark mode — text #f0f0f0 on #1a1a1a (~14:1); link #7ab3e8 (~7.7:1). accent-color: add accent-color: #003781 to :root (closes issue #1). CSS: add @supports dynamic-type block for WebKit, fix :focus -> :focus-visible in dark mode, fix * :disabled -> *:disabled, add gap to .grid-wrapper, add padding-inline to body, remove all empty rule blocks and unused --bright-green / color-gamut media query, add font-family: inherit to design-01 tier, add minimal nav styles. OTP: move label before input, use visible text "One-time code", remove title-tooltip fallback. Behaviour.js: remove Generator prototype and hasAttr helper (only used by the now-removed skip-link generator), tighten debug check to window.location.hostname comparison. https://claude.ai/code/session_01JwsuyxwfMZfKQhT9twfkRY
Minimal Design tier (design-02): - Consolidate two '(tbd)' checkboxes into one 'Minimal Design' checkbox - Implement full Allianz Blue (#003781) styling: border, border-radius, padding, focus outline using var(--color-link) so dark mode adapts - Button/submit/reset get blue background with accessible contrast New form element sections (10 added, all with 5-state grid): - Email, Telephone, URL, Number, Search, Date, Time - Color (required + read-only marked 'Not available') - File (pre-filled + read-only marked 'Not available') - Buttons: comparison of button vs input[type=submit/reset] across default and disabled states using 5-column grid Indeterminate checkbox: - New 'Indeterminate' variant in Checkbox Group section - Set via JS (el.indeterminate = true); cannot be done in HTML Cleanup: - Remove <fieldset><legend><h3> testing artifact entirely - Replace loose <div role="group"> with <section id="section-aria-group"> with proper heading and description (closes issue #3) - Fix duplicate name="check-choose" in ARIA group section - Nav updated with all 22 sections (was 11) behaviour.js: - Fix .attr('checked', true) -> .prop() + immediate body class add so Streamline typography is visible on first load without interaction https://claude.ai/code/session_01JwsuyxwfMZfKQhT9twfkRY
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
oninputSyntaxError,design-basic.cssinvalid CSS, patterntitlemismatch, empty<h2>removed<details>/<summary>nav listing all 22 sections; each fieldset gets a stableid#111111/#f5f5f5, dark#f0f0f0/#1a1a1a, links pass in both modesaccent-color—#003781added to:root(closes Add accent-color CSS #1)<div>replaced with a proper documented section (closes Add ARIA group example #3)<fieldset><legend><h3>testing artifact removed,@supportsdynamic type for WebKit added,:focus→:focus-visible,* :disabled→*:disabled, gap on grid, dead CSS rules removed