Skip to content

Cherry Pick Add public API to trigger Login for Admin flow. (#4026)#4028

Merged
brandonpage merged 1 commit intoforcedotcom:masterfrom
brandonpage:cherry-pick/login-for-admin-public-api
May 5, 2026
Merged

Cherry Pick Add public API to trigger Login for Admin flow. (#4026)#4028
brandonpage merged 1 commit intoforcedotcom:masterfrom
brandonpage:cherry-pick/login-for-admin-public-api

Conversation

@brandonpage
Copy link
Copy Markdown
Contributor

No description provided.

* Add public API to trigger Login for Admin flow.

* Improve code documentation for loginViewControllerDidSelectLoginForAdmin.
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 5, 2026

1 Error
🚫 Please re-submit this PR to the dev branch, we may have already fixed your issue.

Generated by 🚫 Danger

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 5, 2026

1 Warning
⚠️ Static Analysis found an issue with one or more files you modified. Please fix the issue(s).

Clang Static Analysis Issues

File Type Category Description Line Col
SFUserAccountManager Nullability Memory error Null passed to a callee that requires a non-null 2nd parameter 1579 15
SFUserAccountManager Nullability Memory error Null passed to a callee that requires a non-null 2nd parameter 1594 15
SFUserAccountManager Nullability Memory error nil passed to a callee that requires a non-null 2nd parameter 2229 13

Generated by 🚫 Danger

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 5, 2026

TestsPassedSkippedFailed ❌️
AuthFlowTester UI Test Results all1 ran1 ❌
TestResult
AuthFlowTester UI Test Results all
AuthFlowTesterUITests.xctest
LegacyLoginTests.testCAOpaque_DefaultScopes_WebServerFlow()❌ failure

@codecov
Copy link
Copy Markdown

codecov Bot commented May 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.37%. Comparing base (fe97c22) to head (5d3b879).
⚠️ Report is 343 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4028      +/-   ##
==========================================
+ Coverage   63.35%   65.37%   +2.01%     
==========================================
  Files         250      260      +10     
  Lines       21659    22533     +874     
==========================================
+ Hits        13723    14730    +1007     
+ Misses       7936     7803     -133     
Components Coverage Δ
Analytics 70.78% <ø> (ø)
Common 69.75% <66.66%> (+0.35%) ⬆️
Core 57.31% <71.13%> (+3.52%) ⬆️
SmartStore 74.70% <100.00%> (+0.70%) ⬆️
MobileSync 87.41% <ø> (ø)
see 37 files with indirect coverage changes
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 5, 2026

TestsPassed ✅SkippedFailed
SalesforceSDKCore iOS ^18 Test Results627 ran627 ✅
TestResult
No test annotations available

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 5, 2026

TestsPassed ☑️SkippedFailed ❌️
SalesforceSDKCore iOS ^26 Test Results627 ran625 ✅2 ❌
TestResult
SalesforceSDKCore iOS ^26 Test Results
testNonCallbackURL()❌ failure
SFUserAccountManagerTests.testAuthHandler❌ failure

@brandonpage brandonpage merged commit 64799cd into forcedotcom:master May 5, 2026
24 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants