Add Login for Admin feature.#4022
Merged
brandonpage merged 5 commits intoforcedotcom:devfrom Apr 24, 2026
Merged
Conversation
Clang Static Analysis Issues
Generated by 🚫 Danger |
|
||||||||||||||||||||||||
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #4022 +/- ##
==========================================
- Coverage 70.42% 67.24% -3.19%
==========================================
Files 246 253 +7
Lines 22326 22346 +20
==========================================
- Hits 15724 15026 -698
- Misses 6602 7320 +718
🚀 New features to boost your workflow:
|
|
||||||||||||||||||||
|
||||||||||||||
bbirman
reviewed
Apr 23, 2026
|
|
||
| // Validate | ||
| // Login for Admin always uses web server flow regardless of the useWebServerFlow setting | ||
| let effectiveUseWebServerFlow = loginForAdmin ? true : useWebServerFlow |
Member
There was a problem hiding this comment.
nit: could this be let effectiveUseWebServerFlow = loginForAdmin || useWebServerFlow?
bbirman
approved these changes
Apr 23, 2026
brandonpage
added a commit
that referenced
this pull request
Apr 24, 2026
Add Login for Admin feature.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I want feedback as early as possible, but I will leave it in draft until there is adequate test coverage.
The trickiest part is probably handling cancelling the new option:
login_for_admin_cancel.mov