Integrate Scraparr in Servarr as dependency

[mrgionsi]

Please check if the PR fulfills these requirements

• The branch naming convention follows our guidelines
• Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Feature: Introduce scraparr as subchart

What is the current behavior? (You can also link to an open issue here)

There is no mechanism for exporting metrics for servarr

What is the new behavior (if this is a feature change)?

Scarparr is introducing metrics to be used in prometheus.

Closes #55

[mrgionsi]

@imgios I have added api_version ( with default value v3 ) for scraparr. Should the helm chart support this in the future in case someone wants to change it?

[imgios]

@imgios I have added api_version ( with default value v3 ) for scraparr. Should the helm chart support this in the future in case someone wants to change it?

This is an optional value, having it there is perfectly fine and future proof in my opinion.

[imgios]

@mrgionsi thanks for the contribution, it looks good so far!

I think we need to do some magic tricks to get the default values for the services URL param (e.g. servarr service name directly in scraparr configuration). As a result of your changes, the user is now required to manually fill in the URL values, which is not really the aim of servarr. Not sure if we want to include these changes in this PR or merge this and perform this development on another PR.

@fonzdm what's your POV here?

[imgios]

Hi @mrgionsi, in addition to the previous message, just a few comments to point out what might be wrong.

For some reason, I didn't include these changes in the previous review.

[imgios]

Hi @mrgionsi, just saw your latest changes and leaved few comments here and there.

[mrgionsi]

Hi @mrgionsi, I think you still forgot some typos behind. Can you please fix them? 🤓

Thanks @imgios. Finally I understood what was wrong, I hope

[imgios]

So far so good, nice one! 🚀

Just one thing, this needs to be tested before merging into dev branch.

[mrgionsi]

So far so good, nice one! 🚀

Just one thing, this needs to be tested before merging into dev branch.

Thanks mate.

@fonzdm Can you please test it and in case approve pr?

[fonzdm]

So far so good, nice one! 🚀
Just one thing, this needs to be tested before merging into dev branch.

Thanks mate.

@fonzdm Can you please test it and in case approve pr?

I'm sorry, did you even try something before creating a PR???

[fonzdm]

Joking, I will try asap 😁

[imgios]

Joking, I will try asap 😁

Thanks for your valuable feedback.