fix(tmux): forward nav keys directly to mux pane on Windows psmux#262
Open
john-mutuma wants to merge 1 commit intofolke:mainfrom
Open
fix(tmux): forward nav keys directly to mux pane on Windows psmux#262john-mutuma wants to merge 1 commit intofolke:mainfrom
john-mutuma wants to merge 1 commit intofolke:mainfrom
Conversation
john-mutuma
changed the title
john-mutuma
force-pushed
the
fix/windows-tmux-nav-passthrough
branch
2 times, most recently
from
4cb1bc3 to
3cabaf1
Compare
john-mutuma
force-pushed
the
fix/windows-tmux-nav-passthrough
branch
from
3cabaf1 to
696c14c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On Windows with psmux, control keys like
C-jpassed through Neovim's terminal emulation get mangled —C-j(newline) becomesCR(submit). This PR fixes the issue by routing nav key passthrough directly throughtmux send-keyswhen a mux parent is available, bypassing the terminal translation layer entirely.Changes
lua/sidekick/cli/session/tmux.lua: Addsend_key()method that sends raw keys viatmux send-keystargeting by session name.lua/sidekick/cli/actions.lua: In thenav()passthrough case (at edge or float), detect mux parent withsend_keysupport and route the key directly to the mux pane instead of returning it as anexprstring.Testing
Manually tested on Windows with psmux:
<C-j>now correctly inserts a newline in CLI tool prompts instead of submitting.