Skip to content

Add Chinese localization guidance#153

Open
lizy-coding wants to merge 2 commits into
flutter:mainfrom
lizy-coding:main
Open

Add Chinese localization guidance#153
lizy-coding wants to merge 2 commits into
flutter:mainfrom
lizy-coding:main

Conversation

@lizy-coding
Copy link
Copy Markdown

Summary

This PR adds Chinese localization guidance to help Chinese-speaking users better understand how to use and contribute to the project.

Changes

  • Added Chinese localization guidance
  • Improved accessibility for Chinese-speaking contributors
  • Clarified localized documentation usage and contribution expectations

Motivation

Chinese-speaking users may need clearer localized guidance when reading, using, or contributing to this project. This update improves documentation accessibility and lowers the barrier for participation.

Testing

  • Documentation-only change
  • No code changes

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Flutter localization guide to include workflows and examples for Chinese localization, including adding Chinese ARB files and configuring Chinese locales. The reviewer suggested keeping the Spanish locale in the example configuration to maintain consistency with other sections of the guide that still reference Spanish localization.

Comment on lines +109 to +110
Locale('zh'), // Chinese
Locale('zh', 'CN'), // Simplified Chinese, China
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

In the Implementation Workflow section (lines 133-138), app_es.arb is still used as the primary example of adding other locales. However, Locale('es') was removed from the supportedLocales list here. To maintain consistency throughout the guide, it is better to keep Spanish in the supportedLocales list alongside the newly added Chinese locales.

Suggested change
Locale('zh'), // Chinese
Locale('zh', 'CN'), // Simplified Chinese, China
Locale('es'), // Spanish
Locale('zh'), // Chinese
Locale('zh', 'CN'), // Simplified Chinese, China

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a documentation-only PR. The pending checks appear to require maintainer approval before running. Please approve them when convenient. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant