Skip to content

[google_maps_flutter] Remove duplicated privacy manifest entries#11791

Open
stuartmorgan-g wants to merge 2 commits into
flutter:mainfrom
stuartmorgan-g:maps-sdk-versions-remove-manifest-copies
Open

[google_maps_flutter] Remove duplicated privacy manifest entries#11791
stuartmorgan-g wants to merge 2 commits into
flutter:mainfrom
stuartmorgan-g:maps-sdk-versions-remove-manifest-copies

Conversation

@stuartmorgan-g
Copy link
Copy Markdown
Collaborator

Google Maps SDK 8.4 didn't include a privacy manifest, just instructions for clients to download and manually add one. Rather than push that requirement onto plugin clients, we duplicated all of the relevant manifest entries into the plugin's manifest.

Starting with 9.0.0 the Google Maps SDK includes its own manifest, so we no longer need to bundle it ourselves when we know that the SDK is 9+. Since that's the case for the SDK-specific copies of the implementation package, we can remove it there, while leaving it in google_maps_flutter_ios (which can still resolve to 8.4).

Fixes flutter/flutter#146838

Pre-Review Checklist

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. 2

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes duplicated privacy manifest entries from the PrivacyInfo.xcprivacy files in both the google_maps_flutter_ios_sdk9 and google_maps_flutter_ios_sdk10 packages. Additionally, the package versions are bumped to 2.18.3 and the changes are documented in their respective changelogs. There are no review comments, and I have no feedback to provide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[google_maps_flutter] Remove GoogleMapsPrivacy manifest entries from plugin after future SDK update

1 participant