[google_maps_flutter] Remove duplicated privacy manifest entries#11791
Open
stuartmorgan-g wants to merge 2 commits into
Open
[google_maps_flutter] Remove duplicated privacy manifest entries#11791stuartmorgan-g wants to merge 2 commits into
stuartmorgan-g wants to merge 2 commits into
Conversation
There was a problem hiding this comment.
Code Review
This pull request removes duplicated privacy manifest entries from the PrivacyInfo.xcprivacy files in both the google_maps_flutter_ios_sdk9 and google_maps_flutter_ios_sdk10 packages. Additionally, the package versions are bumped to 2.18.3 and the changes are documented in their respective changelogs. There are no review comments, and I have no feedback to provide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Google Maps SDK 8.4 didn't include a privacy manifest, just instructions for clients to download and manually add one. Rather than push that requirement onto plugin clients, we duplicated all of the relevant manifest entries into the plugin's manifest.
Starting with 9.0.0 the Google Maps SDK includes its own manifest, so we no longer need to bundle it ourselves when we know that the SDK is 9+. Since that's the case for the SDK-specific copies of the implementation package, we can remove it there, while leaving it in
google_maps_flutter_ios(which can still resolve to 8.4).Fixes flutter/flutter#146838
Pre-Review Checklist
[shared_preferences]///).Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2