Skip to content

[google_maps_flutter] Federate READMEs#11790

Open
stuartmorgan-g wants to merge 6 commits into
flutter:mainfrom
stuartmorgan-g:maps-federate-readmes
Open

[google_maps_flutter] Federate READMEs#11790
stuartmorgan-g wants to merge 6 commits into
flutter:mainfrom
stuartmorgan-g:maps-federate-readmes

Conversation

@stuartmorgan-g
Copy link
Copy Markdown
Collaborator

Moves the platform-specific setup logic and discussion from the main README to the platform READMEs, per our current best practice.

As part of the move, I simplified the discussion of the iOS implementation package choice somewhat, since I realized there was too much explanation of why things are the way they are, rather than on the steps a client should take.

There's a repeated example code block across the iOS packages now, but I think duplicating that is much better than being inconsistent about where setup info is (or worse, pointing them to one implementation package that's not the same as the one they are using).

Part of flutter/flutter#182772

Pre-Review Checklist

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. 2

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the documentation across multiple Google Maps Flutter packages to centralize platform-specific setup instructions. Instead of duplicating detailed setup steps in the main package README, it now links directly to the platform-specific implementation packages (Android, iOS, and Web) and adds the corresponding setup guides to their respective README files. Feedback is provided regarding the formatting of the documentation, including correcting the indentation of nested code blocks in the Web README, aligning XML attributes in the Android README, and suggesting direct anchor links for the iOS setup sections.

Comment thread packages/google_maps_flutter/google_maps_flutter/README.md
Comment thread packages/google_maps_flutter/google_maps_flutter_web/README.md Outdated
Comment thread packages/google_maps_flutter/google_maps_flutter_android/README.md
@github-actions github-actions Bot removed the CICD Run CI/CD label May 26, 2026
@stuartmorgan-g stuartmorgan-g added the CICD Run CI/CD label May 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant