[material_ui] Set up gen_defaults sub-directory#11762
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces a new 'Token Defaults Generator' tool in the material_ui package, consisting of a command-line script, a base template class for code generation, and unit tests. Review feedback identifies a discrepancy between the documented and implemented output paths, a typo in the SDK version constraint which is incompatible with the workspace resolution feature, and a potential runtime error when creating files in non-existent directories.
|
Do you think whether naming the folder |
QuncCccccc
left a comment
There was a problem hiding this comment.
Overall LGTM! Just left some comments.
Good point, renamed to M3
M3E
|
m3e_gen_defaults sub-directorygen_defaults sub-directory
QuncCccccc
left a comment
There was a problem hiding this comment.
LGTM! Thanks for set it up!🎉
The output structure looks good to me! Thanks for the update! |
Work towards flutter/flutter#186906
Adds the initial
gen_defaultssub-directory with the initialTokenTemplateand generator. This is simply the initial scaffold, we will need to add additional helper functions as necessary as we begin adding the actual templates.Pre-Review Checklist
[shared_preferences]///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2