-
Notifications
You must be signed in to change notification settings - Fork 3.8k
[url_launcher_android] Fix WebView content obscured by navigation bar on Android 15+ #11750
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Ann3388p
wants to merge
4
commits into
flutter:main
Choose a base branch
from
Ann3388p:fix/url-launcher-android-edge-to-edge-clean
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
74ff147
fix: handle edge-to-edge insets in WebViewActivity for Android 15+
Ann3388p 9819bac
fix: address review comments - fix imports and indentation
Ann3388p 3f4682d
fix: apply google-java-format to WebViewActivityTest
Ann3388p 3f011f4
fix: add code comment for window insets listener
Ann3388p File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
26 changes: 25 additions & 1 deletion
26
...her_android/android/src/test/java/io/flutter/plugins/urllauncher/WebViewActivityTest.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,17 +1,41 @@ | ||
| // Copyright 2013 The Flutter Authors | ||
| // Use of this source code is governed by a BSD-style license that can be | ||
| // found in the LICENSE file. | ||
|
|
||
| package io.flutter.plugins.urllauncher; | ||
|
|
||
| import static org.junit.Assert.assertEquals; | ||
| import static org.junit.Assert.assertNotNull; | ||
|
|
||
| import android.os.Bundle; | ||
| import androidx.test.core.app.ApplicationProvider; | ||
| import java.util.Collections; | ||
| import org.junit.Test; | ||
| import org.junit.runner.RunWith; | ||
| import org.robolectric.Robolectric; | ||
| import org.robolectric.RobolectricTestRunner; | ||
|
|
||
| @RunWith(RobolectricTestRunner.class) | ||
| public class WebViewActivityTest { | ||
|
|
||
| @Test | ||
| public void extractHeaders_returnsEmptyMapWhenHeadersBundleNull() { | ||
| assertEquals(WebViewActivity.extractHeaders(null), Collections.emptyMap()); | ||
| } | ||
|
|
||
| @Test | ||
| public void onCreate_webviewIsNotNull() { | ||
| WebViewActivity activity = | ||
| Robolectric.buildActivity( | ||
| WebViewActivity.class, | ||
| WebViewActivity.createIntent( | ||
| ApplicationProvider.getApplicationContext(), | ||
| "https://flutter.dev", | ||
| false, | ||
| false, | ||
| new Bundle())) | ||
| .create() | ||
| .get(); | ||
|
|
||
| assertNotNull(activity.webview); | ||
| } | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The indentation of the
Robolectric.buildActivitycall is inconsistent with the 2-space indentation used in the project.References