[google_sign_in_android] Remove usesCleartextTraffic #11077
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests or get an explicit test exemption before merging. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. If you believe this PR qualifies for a test exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
The pull request removes the deprecated android:usesCleartextTraffic="true" attribute from the AndroidManifest.xml file in the debug example application. This change aligns with modern Android development practices that discourage cleartext traffic for security reasons. The PR description indicates that all pre-review checklist items have been addressed.
|
test-exempt: configuration change |
stuartmorgan-g
left a comment
stuartmorgan-g
left a comment
There was a problem hiding this comment.
LGTM
(The disabled Espresso test doesn't use espresso, so no network config needed even if we re-enable it.)
mboetger
added
the
autosubmit
flutter/packages@062c8d4...acd9adb 2026-02-24 matt.boetger@gmail.com [google_sign_in_android] Remove usesCleartextTraffic (flutter/packages#11077) 2026-02-24 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump com.google.maps.android:android-maps-utils from 4.0.0 to 4.1.0 in /packages/google_maps_flutter/google_maps_flutter_android/android (flutter/packages#11099) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…r#182889) flutter/packages@062c8d4...acd9adb 2026-02-24 matt.boetger@gmail.com [google_sign_in_android] Remove usesCleartextTraffic (flutter/packages#11077) 2026-02-24 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump com.google.maps.android:android-maps-utils from 4.0.0 to 4.1.0 in /packages/google_maps_flutter/google_maps_flutter_android/android (flutter/packages#11099) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Removes deprecated usesCleartextTraffic. Addresses: #182553 ## Pre-Review Checklist
…r#182889) flutter/packages@062c8d4...acd9adb 2026-02-24 matt.boetger@gmail.com [google_sign_in_android] Remove usesCleartextTraffic (flutter/packages#11077) 2026-02-24 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump com.google.maps.android:android-maps-utils from 4.0.0 to 4.1.0 in /packages/google_maps_flutter/google_maps_flutter_android/android (flutter/packages#11099) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
2 participants
Removes deprecated usesCleartextTraffic.
Addresses: flutter/flutter#182553
Pre-Review Checklist
[shared_preferences]pubspec.yamlwith an appropriate new version according to the [pub versioning philosophy], or I have commented below to indicate which [version change exemption] this PR falls under[^1].CHANGELOG.mdto add a description of the change, [following repository CHANGELOG style], or I have commented below to indicate which [CHANGELOG exemption] this PR falls under[^1].///).