test: convert functional tests into proper python tests#325
Open
ylatuya wants to merge 1 commit intofluendo:masterfrom
Open
test: convert functional tests into proper python tests#325ylatuya wants to merge 1 commit intofluendo:masterfrom
ylatuya wants to merge 1 commit intofluendo:masterfrom
Conversation
ylatuya
force-pushed
the
unittest
branch
2 times, most recently
from
a8cc672 to
2c60796
Compare
Contributor
Author
|
@mdimopoulos can you please review this? |
Contributor
Author
|
@rsanchez87 can you please review this? |
Contributor
|
CI is failing due to There is no quick fix possible since the result checksums are decoder-dependent, we need to wait for the ITU server to recover or find alternative mirrors. Unrelated to this PR. |
rsanchez87
requested changes
Apr 29, 2026
|
|
||
| class TestReference(unittest.TestCase): | ||
| def setUp(self) -> None: | ||
| run_fluster(["download", "dummy", "-k"]) |
Contributor
There was a problem hiding this comment.
setUp ignores the return value, if the download fails, the test crashes with FileNotFoundError instead of a clean skip,
reproduced locally after rm -rf resources/dummy
maybe this is a solution:
if result.returncode != 0:
self.skipTest(f"Download failed: {result.stderr}")
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.