Conversation
| } | ||
|
|
||
|
|
||
| func (this *WatcherJob) Stop() error { |
There was a problem hiding this comment.
exported method WatcherJob.Stop should have comment or be unexported
receiver name should be a reflection of its identity; don't use generic names such as "me", "this", or "self"
| return this.cmd.Run() | ||
| } | ||
|
|
||
| func (this *WatcherJob) Stop() error { |
There was a problem hiding this comment.
exported method WatcherJob.Stop should have comment or be unexported
receiver name should be a reflection of its identity; don't use generic names such as "me", "this", or "self"
| OutPipe io.Writer | ||
| } | ||
|
|
||
| func (this*WatcherJob) Start() error { |
There was a problem hiding this comment.
exported method WatcherJob.Start should have comment or be unexported
receiver name should be a reflection of its identity; don't use generic names such as "me", "this", or "self"
| "syscall" | ||
| ) | ||
|
|
||
| type WatcherJob struct { |
There was a problem hiding this comment.
exported type WatcherJob should have comment or be unexported
| return job.Cmd.Run() | ||
| } | ||
|
|
||
| func (job *WatcherJob) Stop() error { |
There was a problem hiding this comment.
exported method WatcherJob.Stop should have comment or be unexported
| OutPipe io.Writer | ||
| } | ||
|
|
||
| func (job *WatcherJob) Start() error { |
There was a problem hiding this comment.
exported method WatcherJob.Start should have comment or be unexported
| "syscall" | ||
| ) | ||
|
|
||
| type WatcherJob struct { |
There was a problem hiding this comment.
exported type WatcherJob should have comment or be unexported
| } | ||
|
|
||
|
|
||
| func GetApp() *cli.App { |
There was a problem hiding this comment.
exported function GetApp should have comment or be unexported
| "github.com/urfave/cli" | ||
| ) | ||
|
|
||
| func GetLogger(level zapcore.Level) *zap.Logger { |
There was a problem hiding this comment.
exported function GetLogger should have comment or be unexported
2 similar comments
kubaj
force-pushed
the
feature/refactor
branch
from
dca48d3 to
11d699a
Compare
| } | ||
|
|
||
| // Stop is function that kills job | ||
| func (this *WatcherJob) Stop() error { |
There was a problem hiding this comment.
receiver name should be a reflection of its identity; don't use generic names such as "me", "this", or "self"
| } | ||
|
|
||
| // Start is function that runs job's bash command | ||
| func (this*WatcherJob) Start() error { |
There was a problem hiding this comment.
receiver name should be a reflection of its identity; don't use generic names such as "me", "this", or "self"
| } | ||
|
|
||
| // Stop is function that kills job | ||
| func (this *WatcherJob) Stop() error { |
There was a problem hiding this comment.
receiver name should be a reflection of its identity; don't use generic names such as "me", "this", or "self"
| } | ||
|
|
||
| // Start is function that runs job's bash command | ||
| func (this*WatcherJob) Start() error { |
There was a problem hiding this comment.
receiver name should be a reflection of its identity; don't use generic names such as "me", "this", or "self"
| } | ||
|
|
||
| // Stop is function that kills job | ||
| func (this *WatcherJob) Stop() error { |
There was a problem hiding this comment.
receiver name should be a reflection of its identity; don't use generic names such as "me", "this", or "self"
| } | ||
|
|
||
| // Start is function that runs job's bash command | ||
| func (this*WatcherJob) Start() error { |
There was a problem hiding this comment.
receiver name should be a reflection of its identity; don't use generic names such as "me", "this", or "self"
kubaj
force-pushed
the
feature/refactor
branch
from
11d699a to
b7244e1
Compare
3 participants
No description provided.