Conversation
| * @param segment - An optional segment within the page to link to (e.g., a header anchor). | ||
| */ | ||
| linkPage(pageName: ValidWikiDocumentTargetsNoSuffix | keyof typeof ConstantWikiLinkInfo, linkText?: string, segment?: string): string; | ||
| linkPage<T extends DocMakerLike[]>(pageName: ValidWikiDocumentTargetsNoSuffix<T> | keyof typeof ConstantWikiLinkInfo, linkText?: string, segment?: string): string; |
There was a problem hiding this comment.
I wanted to have this generic on the interface level, but would always end up in a circular dependency between the individual DocMaker implementations and the DocMakerLike[] constraint
There was a problem hiding this comment.
We should also consider how we want to (type-safely) link to the flowR wiki from other wikis
There was a problem hiding this comment.
jeah, lets talk about that with time, i can also try to make this transition - getting this type safe with external projects is a little bit harder but easily doable (i imagine a generic on the interface level which defaults to flowR and that is then initialized type-wise with the respective context)
|
it is fine so far but I dislike the generics directly at the use of e.g. |
2 participants
This PR tracks the necessary changes to the flowR wiki in order to generalize it for usage within multiple projects.
Locally, I currently have this hacky solution of symlinking the
dist/srcdirectory of flowR into the other project'snode_modules: