This repository was archived by the owner on Feb 8, 2022. It is now read-only.
modify HOUR_OF_DAY and TimeZone code#325
Open
yeojoy wants to merge 7 commits intoflorent37:masterfrom
Open
Conversation
added 2 commits
July 26, 2021 11:30
getHour and getHourOfDay both are using Calendar.HOUR. So when I set isAmPm is false afternoon, it always shows between 1 and 12.
When sets a timezone into DatePicker, it does not take it. Because SingleDateAndTimePicker does not refresh dateHelper objects at each WheelViews. So add 3 lines codes for update them.
Author
|
I add one more fix to resole an issue of TimeZone. |
With isAmPm is true, I open time picker. Before noon, it is ok. However afternoon, hour is fixed with 11. After select an hour then open it, this case, the hour is fixed. I just update default vaule when call setIsAmPm in WheelHourPicker. I think at 13:00, and isAmPm true, defaultValue should be 1.
With isAmPm is true, I open time picker. Before noon, it is ok. However afternoon, hour is fixed with 11. After select an hour then open it, this case, the hour is fixed. I just update default vaule when call setIsAmPm in WheelHourPicker. I think at 13:00, and isAmPm true, defaultValue should be 1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getHour and getHourOfDay both are using Calendar.HOUR.
So when I set isAmPm is false afternoon, it always shows
between 1 and 12.