This repository was archived by the owner on Feb 8, 2022. It is now read-only.
Fixed the issue about Feb. 31 or Apr. 31 (issue #166)#312
Open
chinalwb wants to merge 1 commit intoflorent37:masterfrom
Open
Fixed the issue about Feb. 31 or Apr. 31 (issue #166)#312chinalwb wants to merge 1 commit intoflorent37:masterfrom
chinalwb wants to merge 1 commit intoflorent37:masterfrom
Conversation
Author
|
Hi @florent37 , thanks for the great work! Please take a look about this PR when you have some time, I hope it helps but not introduces new issues. I am about to work out another PR for including this feature: #161 (comment), please let me know what do you think about it. Have a nice day guy! And Happy New Year, get a much better 2021! Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixed the issue mentioned in #166 , we should never show Feb. 31 or Apr. 31.
How to test manually?
To reproduce:
Click me to open single dialogTo verify:
chinalwb/SingleDateAndTimePickerExpected Behavior