fix: resolve properties for @Serializable target classes#21
Merged
Conversation
Remove the FirBinaryDependenciesModuleData check that prevented property resolution for types involving binary dependencies. This blocked mapping to @serializable target classes because the serialization compiler plugin adds synthetic properties from binary module data. Also refactor IntegrationTest to support additional Gradle plugins and dependencies, enabling integration tests with kotlinx.serialization. Closes #20 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FirBinaryDependenciesModuleDatacheck inresolvePropertyFields()that prevented property resolution for@Serializabletarget classesIntegrationTestto support additional Gradle plugins and dependencies viaOptionsSerializableTestwith three integration tests: auto-map with@Serializabletarget,@Serializablewith sealed interface, and fully auto-mapped@SerializablefieldsCloses #20
Test plan
SerializableTest.shouldCompile_autoMapWithSerializableTargetpassesSerializableTest.shouldCompile_autoMapWithSerializableAndSealedInterfacepassesSerializableTest.shouldCompile_allFieldsAutoMappedWithSerializablepasses🤖 Generated with Claude Code