Enhance toolbox search: index categories, normalize queries, add category open buttons and styles#328
Closed
tracygardner wants to merge 1 commit intomainfrom
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
getBlocksFromToolboxwithgetSearchableToolboxItemsthat returns bothtoolboxBlocksandtoolboxCategories, and avoids indexing search-only toolbox entries.normalizeSearchSegmentandnormalizePathKey, andresolveToolboxName/resolveCategoryColourto handle localized names and category colours/styles consistently.createXmlFromJson+ button XML when a match is a category.scoreMatchcomparator to prioritize category matches, exact matches, prefixes, and then alphabetic order, and wired sorting intoshowMatchingBlocks.SEARCH_OPEN_CATEGORYbutton callback that finds the matching toolbox category, expands parents, selects it, and focuses the toolbox/flyout to open the category contents.style.cssfor.blocklyFlyoutButton.search-category-resultto style category-result buttons with a configurable--search-category-colourvariable.requestIdleCallback/setTimeout) and preserved existing search initialization patching logic.Testing
npm run lintand they completed successfully.npm run buildand the build succeeded without errors.npm testand all automated tests passed.Codex Task