feat: detect core type for AuthenticAMD#1984
Open
mauri870 wants to merge 1 commit intoflightlessmango:masterfrom
Open
feat: detect core type for AuthenticAMD#1984mauri870 wants to merge 1 commit intoflightlessmango:masterfrom
mauri870 wants to merge 1 commit intoflightlessmango:masterfrom
Conversation
Author
|
@flightlessmango Friendly ping for review |
Owner
|
Could you please clean up the commit history before we proceed? There are several intermediate commits that make it harder to review |
Currently enabling the "Core Type" option in AMD cpus results in an "unknown" label for each core. Implement detection of X3D cores and frequency cores by inspecting the cpu model name and L3 cache topology.
Author
Sure, I've squashed everything into a single commit. Also, with the newly announced 9950X3D2, I took another look at the logic. It should still work fine with dual X3D CCD CPUs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently enabling the "Core Type" option in AMD cpus results in an "unknown" label for each core.
Implement detection of X3D cores and frequency cores by inspecting the cpu model name and L3 cache topology.
Fixes #1933
9950X3D shows: