Skip to content

param: cellpadding_x#1398

Open
Grief wants to merge 2 commits intoflightlessmango:masterfrom
Grief:master
Open

param: cellpadding_x#1398
Grief wants to merge 2 commits intoflightlessmango:masterfrom
Grief:master

Conversation

@Grief
Copy link
Copy Markdown

@Grief Grief commented Aug 8, 2024

This allows to make the overlay smaller than it was possible before:
image

@flightlessmango
Copy link
Copy Markdown
Owner

What does this look like in horizontal and what happens with the recording dot?
Is cellpadding_x=1 the old default?

@Grief
Copy link
Copy Markdown
Author

Grief commented Aug 10, 2024

@flightlessmango it works the same way, allowing to make the layout more tight
image

or loose
image

the default is cellpadding_x=0 or not defined
image

@flightlessmango
Copy link
Copy Markdown
Owner

I guess my question is if you don't set cellpadding_x, will it have the old spacing?
And what value is the old spacing in cellpadding_x ?

Comment thread src/overlay_params.cpp
params->width = params->font_size * params->font_scale * params->table_columns * 4.6;
const auto real_size = params->font_size * params->font_scale;

params->width = static_cast<uint>(((1.0 + params->cellpadding_x * 2.0) * 4.6) * real_size * params->table_columns);
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mingw compiler doesn't recognize uint, casting as unsigned int should be more portable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants