Skip to content

EDM-3512: Display cli artifacts by tool#623

Open
celdrake wants to merge 2 commits intoflightctl:mainfrom
celdrake:EDM-3512-cli-artifacts-tools
Open

EDM-3512: Display cli artifacts by tool#623
celdrake wants to merge 2 commits intoflightctl:mainfrom
celdrake:EDM-3512-cli-artifacts-tools

Conversation

@celdrake
Copy link
Copy Markdown
Collaborator

@celdrake celdrake commented Apr 20, 2026

Groups the flightctl artifacts by tool that is being added here
If tool is not present, it will try to extract it from the filename.

After unifying the order and naming with the CLIDownloads, the result is:

cli-downloads-UI

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 20, 2026

Warning

Rate limit exceeded

@celdrake has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 50 minutes and 31 seconds before requesting another review.

To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 764664b5-caf9-461b-bbd6-72980e7fd168

📥 Commits

Reviewing files that changed from the base of the PR and between 2e10a91 and 2453a62.

📒 Files selected for processing (5)
  • libs/i18n/locales/en/translation.json
  • libs/ui-components/src/components/Masthead/CommandLineToolsPage.tsx
  • libs/ui-components/src/hooks/useCliArtifacts.ts
  • libs/ui-components/src/types/extraTypes.ts
  • libs/ui-components/src/utils/cliArtifacts.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
Review rate limit: 0/1 reviews remaining, refill in 50 minutes and 31 seconds.

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Collaborator

@rawagner rawagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we align with https://github.com/flightctl/flightctl/blob/main/deploy/helm/flightctl/templates/cli-artifacts/flightctl-cli-artifacts-console.yaml ? in the console artifacts, we show slightly different msgs and links

@fzdarsky
Copy link
Copy Markdown
Contributor

Could we align with https://github.com/flightctl/flightctl/blob/main/deploy/helm/flightctl/templates/cli-artifacts/flightctl-cli-artifacts-console.yaml ? in the console artifacts, we show slightly different msgs and links

Could we further polish the microcopy a bit, e.g. sort by OS, use the correct name "macOS", avoid the double 'for', and use the architecture term native to the OS?

  • Download flightctl for macOS (Intel)
  • Download fligthctl for macOS (Apple Silicon)
  • Download fligthctl for Linux (x86_64)
  • Download flightctl for Linux (ARM64)
  • Download fligthctl for Windows (x86_64)
  • Download flightctl for Windows (ARM64)

Ideally (goes beyond fixing the bug) we'd also provide instructions how to verify the sha256 checksum on each OS.

@celdrake
Copy link
Copy Markdown
Collaborator Author

@rawagner @fzdarsky Thanks for the feedback! I'll see to align this and check with UX in case of doubt.

@celdrake
Copy link
Copy Markdown
Collaborator Author

celdrake commented Apr 30, 2026

@fzdarsky I checked how the CLI downloads show in the OCP console and your suggestion does not align fully with that.

  • OCP console uses the "Download TOOL for OS for ARCH" wording
  • OCP console orders the links, irrespective of how they are defined in the CRD. The case-sensitive alphabetical order make the links appear sorted as: Linux ARM64, Linux x86_64, Mac ARM64, Mac x86_64, then Windows. If we label "Mac" as "macOS", then it would appear as the last OS.
  • Architectures are always being displayed as ARM64 and x86_64 (and ARM64 always appears before x86_64 due to the aforementioned automatic sorting)

I would suggest we keep the same patterns.

In flightctl that would mean changing to what's on flightctl/flightctl#2851, which would appear as follow:
cli-downloads-OCP

Does that sound OK? Then I'd align the UI to match the same patterns.

@celdrake celdrake force-pushed the EDM-3512-cli-artifacts-tools branch from 917307c to eb2ae8e Compare April 30, 2026 13:59
@celdrake celdrake force-pushed the EDM-3512-cli-artifacts-tools branch from eb2ae8e to 2453a62 Compare April 30, 2026 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants