Skip to content

WIP: Refactor Search and ToC#542

Draft
sayanchowdhury wants to merge 3 commits intomainfrom
sayan/update-on-this-page
Draft

WIP: Refactor Search and ToC#542
sayanchowdhury wants to merge 3 commits intomainfrom
sayan/update-on-this-page

Conversation

@sayanchowdhury
Copy link
Copy Markdown
Member

WIP to check the preview. This commit updates the refactors search and ToC

Signed-off-by: Sayan Chowdhury <sayan.chowdhury2012@gmail.com>
Signed-off-by: Sayan Chowdhury <sayan.chowdhury2012@gmail.com>
Signed-off-by: Sayan Chowdhury <sayan.chowdhury2012@gmail.com>
@github-actions
Copy link
Copy Markdown

Azure Static Web Apps: Your stage site is ready! Visit it here: https://lemon-wave-085522403-542.westeurope.1.azurestaticapps.net

Copy link
Copy Markdown
Contributor

@ervcz ervcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice upgrade to the search functionality!

});

// Copy code for codenew shortcode
function copyCode(id) {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This function seems to be uninvoked.

Comment thread Makefile

build-preview: getdeps docs
hugo --theme=flatcar -F -b ${DEPLOY_PRIME_URL}
npx -y pagefind --site public
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
npx -y pagefind --site public
npx -y pagefind@1.4.0 --site public

@ervcz
Copy link
Copy Markdown
Contributor

ervcz commented Mar 20, 2026

Noticed a while ago that the common.js of the theme gets shadowed from the project. Just wanted to share this info, doesn't need to be addressed with this PR necessarily tho as this was an existing condition.

  1. Project asset dir: static/js/common.js (because assetDir: static in config.yaml)
  2. Theme asset dir: themes/flatcar/assets/js/common.js (currently ignored fallback - could be deleted)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants