fix(golang): scope plugin sessions to active config#26
Merged
Conversation
The Golang diagnostics UI could show a session from another config item because sessions were stored globally and sessions-list ignored the active config_id. Store the config item ID on sessions, filter and validate session operations by the current config, and make the UI bind the right pane session to the selected sidebar target.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Golang diagnostics UI could show a session from another config item, e.g. a mission-control session while viewing a config-db page.
Sessions were stored globally and sessions-list ignored the active config_id, while the UI auto-selected the first returned session.
Store the config item ID on sessions, filter and validate session operations by the current config, and make the UI match the right pane session to the selected sidebar target.