fix: make Arthas session creation async and idempotent#21
Merged
Conversation
Arthas session creation can exceed ingress timeouts while attaching to a JVM, causing nginx 504 responses before the plugin finishes. Return a creation job immediately, poll session-creation-status from the UI, and reuse pending jobs or active sessions per namespace/pod/container to avoid duplicate attach flows and port-forwards.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Arthas session creation can exceed ingress timeouts while attaching to a JVM, causing nginx 504s.
Make
session-createreturn immediately with a creation job and let the UI pollsession-creation-statusuntil the session is ready. Reuse pending creation jobs and existing sessions pernamespace/pod/containerso multiple clients targeting the same pod do not spawn duplicate attach flows or port-forwards.