fix: expose plugin UI operations over HTTP#19
Merged
Merged
Conversation
The plugin UI SDK calls operation proxy endpoints with POST bodies, but Arthas and Inspektor Gadget only registered gRPC handlers and did not declare POST HTTP bindings. Mission Control rejected those calls before they reached the plugin, causing forbidden errors such as traces-list not allowing HTTP POST. Declare POST bindings for unary UI operations and register HTTP adapters that invoke the existing handlers with the request body and host context. Include the updated Inspektor Gadget UI checksum.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Arthas and Inspektor Gadget UIs call plugin operations through the HTTP proxy with POST bodies.
Those operations only had gRPC handlers and no POST HTTP bindings, so Mission Control rejected requests before they reached the plugin with errors like
operation "traces-list" does not allow HTTP POST.Declare POST bindings and register HTTP adapters for unary UI operations so the existing handlers can be invoked from the iframe proxy.