fix: use plugin UI SDK in plugin UIs#18
Merged
Merged
Conversation
Arthas UI was constructing plugin operation URLs by hand, which can break when served through the Mission Control plugin UI proxy. Vendor the built plugin UI SDK as a local dependency, use its invoke helper for operations, and signal tab readiness after render.
Inspektor Gadget UI was constructing plugin operation URLs by hand, which can break when served through the Mission Control plugin UI proxy. Vendor the built plugin UI SDK as a local dependency, use its invoke helper for operations, and signal tab readiness through the SDK.
adityathebe
changed the title
Member
Author
|
@coderabbitai review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Arthas and Inspektor Gadget UIs were using hand-rolled plugin operation URLs, which can break under the Mission Control plugin UI proxy.
Vendor the built plugin UI SDK until it is published to npm, and use its invoke helper for operations.
Also signal tab readiness through the SDK after each UI renders.