fix(golang): align plugin UI with SDK routes#17
Merged
Conversation
The Golang plugin UI was calling stale backend paths and its pprof/profile handlers were still wired as plugin-local routes. Declare HTTP bindings for operation proxy routes, route UI calls through the Mission Control proxy API, and adapt profile/pprof handlers to the SDK operation path contract.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Golang plugin UI was calling stale backend paths and some HTTP handlers were still modeled around plugin-local routes.
This aligns the UI with the Mission Control plugin UI contract by routing backend calls through
/proxy/<endpoint>and adapts pprof/profile handlers to the SDK HTTP operation path. It also declares HTTP bindings for the plugin operations so Mission Control can proxy them correctly.