Skip to content

fix: publish release after matrix uploads complete#43

Merged
adityathebe merged 1 commit into
mainfrom
fix/release-draft-before-publish
May 20, 2026
Merged

fix: publish release after matrix uploads complete#43
adityathebe merged 1 commit into
mainfrom
fix/release-draft-before-publish

Conversation

@adityathebe
Copy link
Copy Markdown
Member

@adityathebe adityathebe commented May 20, 2026

Release builds upload assets from multiple matrix jobs.

The first completed matrix job was creating a published GitHub Release, causing later jobs to fail when uploading assets to an immutable release.

Keep the release as a draft during matrix uploads, then publish it in the final release job after all builds complete.

Summary by CodeRabbit

  • Chores
    • Updated release workflow to create releases as drafts before publishing, improving the release process.

Review Change Stack

Release builds upload assets from multiple matrix jobs.

The first completed matrix job was creating a published GitHub Release, causing later jobs to fail when uploading assets to an immutable release.

Keep the release as a draft during matrix uploads, then publish it in the final release job after all builds complete.
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 20, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 015bbe25-076b-4ae3-9d64-3afb42f16a09

📥 Commits

Reviewing files that changed from the base of the PR and between 0fc2375 and 133dc39.

📒 Files selected for processing (1)
  • .github/workflows/release.yml

Walkthrough

The release workflow is updated to manage release drafts. The upload-release-action now creates releases as drafts, and the subsequent release editing step explicitly publishes them after updating title and notes.

Changes

Release Workflow Draft Management

Layer / File(s) Summary
Draft release creation and publication
.github/workflows/release.yml
The upload-release-action step adds draft: true to mark newly created releases as drafts. The subsequent gh release edit command adds --draft=false to publish the draft release after updating the notes and title.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main change: delaying release publication until matrix uploads complete, which matches the primary purpose of keeping releases as drafts during multi-job builds.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/release-draft-before-publish
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch fix/release-draft-before-publish

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@adityathebe adityathebe enabled auto-merge (rebase) May 20, 2026 09:18
@adityathebe adityathebe merged commit 7d210a0 into main May 20, 2026
15 checks passed
@adityathebe adityathebe deleted the fix/release-draft-before-publish branch May 20, 2026 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant