Skip to content

Fix: De-activate animation when scroll container has no overflow #302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dnlzro wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix: De-activate animation when scroll container has no overflow #302

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/scroll-timeline-base.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -473,7 +473,7 @@ export class ScrollTimeline {
const maxScrollPos = calculateMaxScrollOffset(container, axis);

return maxScrollPos > 0 ? CSS.percent(100 * scrollPos / maxScrollPos)
: CSS.percent(100);
: unresolved;
}

get __polyfill() {
Expand Down Expand Up @@ -878,6 +878,10 @@ export class ViewTimeline extends ScrollTimeline {
const offsets = range(this, 'cover');
if (!offsets)
return unresolved;

if (offsets.end === offsets.start)
return unresolved;

const progress =
(scrollPos - offsets.start) / (offsets.end - offsets.start);

Expand Down