Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/webrtc-client/src/tracks/transceivers.ts
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,7 @@ const createSimulcastTransceiverConfig = (
// in other case lower resolution encoding can get
// higher max_bitrate
sendEncodings: calculateSimulcastEncodings(encodings, maxBandwidth),
streams: trackContext.stream ? [trackContext.stream] : [],
};
};

Expand Down
28 changes: 27 additions & 1 deletion packages/webrtc-client/tests/methods/addTrackMethod.test.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,10 @@
import { FakeMediaStreamTrack } from 'fake-mediastreamtrack';
import { expect, it } from 'vitest';

import { WebRTCEndpoint } from '../../src';
import { Variant, WebRTCEndpoint } from '../../src';
import { TrackContextImpl } from '../../src/internal';
import { deserializePeerMediaEvent, serializeServerMediaEvent } from '../../src/mediaEvent';
import { createTransceiverConfig } from '../../src/tracks/transceivers';
import { createConnectedEventWithOneEndpoint, mockTrack } from '../fixtures';
import { mockMediaStream, mockRTCPeerConnection } from '../mocks';

Expand Down Expand Up @@ -51,6 +54,29 @@ it('Adding track updates internal state', () => {
expect(localEndpoint.tracks.size).toBe(1);
});

it('Simulcast transceiver config includes the stream', () => {
const stream = { id: 'test-stream-id' } as MediaStream;
const videoTrack = new FakeMediaStreamTrack({ kind: 'video' });

const trackContext = new TrackContextImpl(
{ id: 'endpoint-1', type: 'webrtc', metadata: undefined, tracks: new Map() },
'track-1',
undefined,
{
enabled: true,
enabledVariants: [Variant.VARIANT_LOW, Variant.VARIANT_MEDIUM, Variant.VARIANT_HIGH],
disabledVariants: [],
},
);
trackContext.track = videoTrack;
trackContext.stream = stream;
trackContext.maxBandwidth = 0;

const config = createTransceiverConfig(trackContext);

expect(config.streams).toEqual([stream]);
});

it('Adding track before being accepted by the server throws error', async () => {
// Given
mockRTCPeerConnection();
Expand Down
Loading