Skip to content
This repository was archived by the owner on Feb 10, 2026. It is now read-only.

feat: add option to configure display name of ios screen broadcast extension #527

Merged
MiloszFilimowski merged 1 commit into from
Dec 11, 2025
Merged

feat: add option to configure display name of ios screen broadcast extension #527

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion internal/fishjam-chat/app.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,8 @@
"ios": {
"enableScreensharing": true,
"enableVoIPBackgroundMode": true,
"supportsPictureInPicture": true
"supportsPictureInPicture": true,
"broadcastExtensionDisplayName": "Fishjam Screen Broadcast"
}
}
],
Expand Down
2 changes: 1 addition & 1 deletion packages/react-native-client/plugin/broadcastExtensionFiles/Info.plist
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
<plist version="1.0">
<dict>
<key>CFBundleDisplayName</key>
<string>FishjamScreenBroadcast</string>
<string>{{DISPLAY_NAME}}</string>
<key>CFBundleExecutable</key>
<string>$(EXECUTABLE_NAME)</string>
<key>CFBundleIdentifier</key>
Expand Down
1 change: 1 addition & 0 deletions packages/react-native-client/plugin/src/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ export type FishjamPluginOptions =
appGroupContainerId?: string;
mainTargetName?: string;
broadcastExtensionTargetName?: string;
broadcastExtensionDisplayName?: string;
};
}
| undefined;
12 changes: 12 additions & 0 deletions packages/react-native-client/plugin/src/withFishjamIos.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,10 @@ function getSbeTargetName(props: FishjamPluginOptions) {
);
}

function getSbeDisplayName(props: FishjamPluginOptions) {
return props?.ios?.broadcastExtensionDisplayName || 'FishjamScreenBroadcast';
}

export function getSbePodfileSnippet(props: FishjamPluginOptions) {
const targetName = getSbeTargetName(props);
return `\ntarget '${targetName}' do\n pod 'FishjamCloudBroadcastClient'\nend`;
Expand All @@ -26,6 +30,7 @@ const TARGETED_DEVICE_FAMILY = `"1,2"`;
const IPHONEOS_DEPLOYMENT_TARGET = '15.1';
const GROUP_IDENTIFIER_TEMPLATE_REGEX = /{{GROUP_IDENTIFIER}}/gm;
const BUNDLE_IDENTIFIER_TEMPLATE_REGEX = /{{BUNDLE_IDENTIFIER}}/gm;
const DISPLAY_NAME_TEMPLATE_REGEX = /{{DISPLAY_NAME}}/gm;

/**
* A helper function for updating a value in a file for given regex
Expand Down Expand Up @@ -249,6 +254,13 @@ const withFishjamSBE: ConfigPlugin<FishjamPluginOptions> = (config, options) =>
bundleIdentifier || '',
options,
);
await updateFileWithRegex(
iosPath,
'Info.plist',
DISPLAY_NAME_TEMPLATE_REGEX,
getSbeDisplayName(options),
options,
);

// Create new PBXGroup for the extension
const extGroup = xcodeProject.addPbxGroup(
Expand Down
Loading