Conversation
There was a problem hiding this comment.
Pull request overview
Updates the Fishjam JS server SDK and generated client/proto types to support a new VAPI peer type and align with the newer Fishjam OpenAPI/protobuf schemas.
Changes:
- Add
createVAPIAgentto the JS server SDK client and update SDK exports accordingly. - Regenerate/upgrade
fishjam-openapiclient types to OpenAPI doc version0.26.1(new peer options/types, token shape changes, track forwarding API/types). - Regenerate/upgrade
fishjam-protoserver notifications (new peer typeVAPI, plus track forwarding + VAD notification messages), and update example app usage.
Reviewed changes
Copilot reviewed 5 out of 10 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/js-server-sdk/src/index.ts | Adjusts SDK public re-exports from fishjam-openapi. |
| packages/js-server-sdk/src/client.ts | Adds createVAPIAgent and consumes new OpenAPI peer options type. |
| packages/fishjam-proto/src/fishjam/server_notifications.ts | Updates server notification message types/enum to include VAPI + new notifications. |
| packages/fishjam-openapi/src/generated/index.ts | Bumps generated OpenAPI doc version header to 0.26.1. |
| packages/fishjam-openapi/src/generated/configuration.ts | Bumps generated OpenAPI doc version header to 0.26.1. |
| packages/fishjam-openapi/src/generated/common.ts | Bumps generated OpenAPI doc version header to 0.26.1. |
| packages/fishjam-openapi/src/generated/base.ts | Bumps generated OpenAPI doc version header to 0.26.1. |
| packages/fishjam-openapi/src/generated/api.ts | Introduces new VAPI peer options/types and track-forwarding API/types; adjusts several response/type shapes. |
| examples/room-manager/src/plugins/fishjam.ts | Updates example to reflect viewer/streamer token type changes. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 6 out of 11 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
czerwiukk
left a comment
czerwiukk
left a comment
There was a problem hiding this comment.
the vapi part is simple and to be approved, but whats the reason for the other small api changes?
| isPublic?: boolean | ||
| ) => Promise<PeerAccessData>; | ||
| getLivestreamViewerToken: (roomName: string) => Promise<ViewerToken>; | ||
| getLivestreamViewerToken: (roomName: string) => Promise<string>; |
There was a problem hiding this comment.
question: what happened that we need to change that in this PR?
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 10 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Description
Motivation and Context
Why is this change required? What problem does it solve? If it fixes an open
issue, please link to the issue here.
Documentation impact
Types of changes
not work as expected)