poh: fix pacing, replace fd_log_wallclock#9056
Merged
jherrera-jump merged 1 commit intofiredancer-io:mainfrom Mar 31, 2026
Merged
poh: fix pacing, replace fd_log_wallclock#9056jherrera-jump merged 1 commit intofiredancer-io:mainfrom
jherrera-jump merged 1 commit intofiredancer-io:mainfrom
Conversation
d5ba6f4 to
cdbb2db
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the PoH tile’s timing/pacing approach by switching from direct fd_log_wallclock() reads to a calibrated fd_clock_t, and hooks clock recalibration into the stem housekeeping path to keep the clock estimate fresh without putting wallclock reads on the critical path.
Changes:
- Add an
fd_clock_tinstance and backing shared-memory region tofd_poh_t, plus a cachedrecal_nexttimestamp. - Initialize the clock in
fd_poh_tileand recalibrate it during stem housekeeping. - Replace
fd_log_wallclock()usage infd_poh_advance()withfd_clock_now().
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/discof/poh/fd_poh_tile.c | Initializes fd_clock_t for PoH and adds a stem housekeeping callback to periodically recalibrate. |
| src/discof/poh/fd_poh.h | Extends fd_poh_t with clock state (fd_clock_t, clock_mem, recal_next) and adds a new timestamp field. |
| src/discof/poh/fd_poh.c | Uses fd_clock_now() for pacing calculations and records a leader begin timestamp. |
cdbb2db to
27b4430
Compare
ripatel-fd
reviewed
Mar 30, 2026
27b4430 to
55a84d7
Compare
ripatel-fd
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.