Skip to content

poh: fix pacing, replace fd_log_wallclock#9056

Merged
jherrera-jump merged 1 commit intofiredancer-io:mainfrom
jherrera-jump:jherrera/poh-fix-pacing
Mar 31, 2026
Merged

poh: fix pacing, replace fd_log_wallclock#9056
jherrera-jump merged 1 commit intofiredancer-io:mainfrom
jherrera-jump:jherrera/poh-fix-pacing

Conversation

@jherrera-jump
Copy link
Copy Markdown
Contributor

No description provided.

@jherrera-jump jherrera-jump force-pushed the jherrera/poh-fix-pacing branch from d5ba6f4 to cdbb2db Compare March 26, 2026 21:32
@jherrera-jump jherrera-jump changed the title poh: fix pacing poh: fix pacing, replace fd_log_wallclock Mar 26, 2026
@jherrera-jump jherrera-jump requested a review from Copilot March 26, 2026 21:32
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the PoH tile’s timing/pacing approach by switching from direct fd_log_wallclock() reads to a calibrated fd_clock_t, and hooks clock recalibration into the stem housekeeping path to keep the clock estimate fresh without putting wallclock reads on the critical path.

Changes:

  • Add an fd_clock_t instance and backing shared-memory region to fd_poh_t, plus a cached recal_next timestamp.
  • Initialize the clock in fd_poh_tile and recalibrate it during stem housekeeping.
  • Replace fd_log_wallclock() usage in fd_poh_advance() with fd_clock_now().

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
src/discof/poh/fd_poh_tile.c Initializes fd_clock_t for PoH and adds a stem housekeeping callback to periodically recalibrate.
src/discof/poh/fd_poh.h Extends fd_poh_t with clock state (fd_clock_t, clock_mem, recal_next) and adds a new timestamp field.
src/discof/poh/fd_poh.c Uses fd_clock_now() for pacing calculations and records a leader begin timestamp.

Comment thread src/discof/poh/fd_poh_tile.c Outdated
Comment thread src/discof/poh/fd_poh.c Outdated
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

@jherrera-jump jherrera-jump marked this pull request as ready for review March 26, 2026 22:56
Comment thread src/discof/poh/fd_poh.c Outdated
@jherrera-jump jherrera-jump marked this pull request as draft March 30, 2026 22:16
@jherrera-jump jherrera-jump force-pushed the jherrera/poh-fix-pacing branch from 27b4430 to 55a84d7 Compare March 30, 2026 22:22
@jherrera-jump jherrera-jump marked this pull request as ready for review March 30, 2026 22:23
Copilot AI review requested due to automatic review settings March 30, 2026 22:23
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

@jherrera-jump jherrera-jump merged commit 609f9a4 into firedancer-io:main Mar 31, 2026
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants