Draft
Conversation
f41c416 to
78be8cb
Compare
78be8cb to
7a0d5bc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Zen5:
Before (GCC):
After (GCC):
This is a 30% speedup, when measured on a Zen 5 machine. The main benefit of the newer approach is that it actually uses AVX512, where the old one was only using AVX2. The new version is also written in Zig, with the generated assembly checked in. This makes auditing the implementation and understanding it much easier.
Icelake:
Before (Clang):
After (Clang):
Icelake benchmarks are more interesting, and more accurate, as LLVM does not yet have scheduling information for Zen5, which makes it schedule somewhat poorly (we could win with more carefully crafted asm that uses zmm registers).